Skip to content

fix(performance): using RocksDBMempoolTipsIndex made the sync too slow#1100

Merged
jansegre merged 1 commit intohotfixfrom
fix/performance-regression
Jul 31, 2024
Merged

fix(performance): using RocksDBMempoolTipsIndex made the sync too slow#1100
jansegre merged 1 commit intohotfixfrom
fix/performance-regression

Conversation

@jansegre
Copy link
Member

Motivation

With the deploy of v0.62.0-rc.1 the sync from scratch took significantly longer than expected. The cause was confirmed to be the use of RocksDBMempoolTipsIndex that was introduced. The simplest solution to quickly advance with the release is to revert to MemoryMempoolTipsIndex.

Acceptance Criteria

  • Revert back to MemoryMempoolTipsIndex for RocksDBIndexesManager.mempool_tips

Checklist

  • If you are requesting a merge into master, confirm this code is production-ready and can be included in future releases as soon as it gets merged

@jansegre jansegre requested review from glevco and msbrogli July 31, 2024 21:59
@jansegre jansegre self-assigned this Jul 31, 2024
@codecov
Copy link

codecov bot commented Jul 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.85%. Comparing base (592f47c) to head (0a60ec7).

Additional details and impacted files
@@            Coverage Diff             @@
##           hotfix    #1100      +/-   ##
==========================================
- Coverage   84.99%   84.85%   -0.14%     
==========================================
  Files         314      314              
  Lines       23957    23957              
  Branches     3621     3621              
==========================================
- Hits        20362    20329      -33     
- Misses       2880     2913      +33     
  Partials      715      715              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants