chore: flake.nix creating a devshell with all fullnode dependencies needed to run the fullnode#1098
Merged
andreabadesso merged 1 commit intomasterfrom Aug 21, 2024
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1098 +/- ##
==========================================
- Coverage 84.80% 84.78% -0.03%
==========================================
Files 315 315
Lines 24071 24071
Branches 3647 3647
==========================================
- Hits 20413 20408 -5
Misses 2941 2941
- Partials 717 722 +5 ☔ View full report in Codecov by Sentry. |
msbrogli
approved these changes
Aug 6, 2024
jansegre
approved these changes
Aug 13, 2024
237759f to
85525f5
Compare
|
| Report | Wed, August 21, 2024 at 15:44:54 UTC |
| Project | hathor-core |
| Branch | chore/add-flake-direnv |
| Testbed | ubuntu-22.04 |
Click to view all benchmark results
| Benchmark | Latency | Latency Results nanoseconds (ns) | (Δ%) | Latency Lower Boundary nanoseconds (ns) | (%) | Latency Upper Boundary nanoseconds (ns) | (%) |
|---|---|---|---|---|
| sync-v2 (up to 20000 blocks) | ✅ (view plot) | 101,426,926,202.14 (-1.83%) | 82,652,997,824.79 (81.49%) | 123,979,496,737.19 (81.81%) |
Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help
fa17355 to
7f05730
Compare
…eded to run the fullnode
7f05730 to
806e0b6
Compare
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Improve developer experience running the fullnode when using nix (with nix-flakes and direnv) by having a reproducible dev environment with fixed versions
Acceptance Criteria
direnvwith all dependencies needed by the fullnode to runFuture possibilities
This flake uses a hybrid approach (nix + poetry), which is fine as poetry has a rich lock file which results in deterministic installs and builds, but we could use poetry2nix to have nix also managing python dependencies. More on this here
Checklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged