chore(cli): mark sync-v1 and bridge as unsafe#1090
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1090 +/- ##
=======================================
Coverage 84.86% 84.86%
=======================================
Files 314 314
Lines 23898 23905 +7
Branches 3611 3613 +2
=======================================
+ Hits 20280 20286 +6
Misses 2906 2906
- Partials 712 713 +1 ☔ View full report in Codecov by Sentry. |
glevco
approved these changes
Jul 24, 2024
2 tasks
msbrogli
approved these changes
Jul 26, 2024
a8de807 to
5e9c6d4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
We're at a point where every node is running only
sync-v2, except for a few nodes that we maintain in bridge mode that runsync-v1 + sync-v2. So for the next release we can safely disincentivizesync-v1from being used either through--sync-v1-onlyor--sync-bridge.Acceptance Criteria
--sync-bridge, mark it as unsafe and unhide--x-sync-bridge(also unsafe) to be used instead--sync-v1-only, mark it as unsafe and add--x-sync-v1-only(also unsafe) to be used instead--sync-v2-only, since it's the default, using it will only show a warningsync-v1should require--unsafe=...to be usedChecklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged