fix(logging): make different version logging less obtrusive#1087
Merged
fix(logging): make different version logging less obtrusive#1087
Conversation
glevco
approved these changes
Jul 18, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1087 +/- ##
==========================================
+ Coverage 84.90% 84.98% +0.08%
==========================================
Files 310 310
Lines 23493 23495 +2
Branches 3549 3549
==========================================
+ Hits 19947 19968 +21
+ Misses 2838 2824 -14
+ Partials 708 703 -5 ☔ View full report in Codecov by Sentry. |
msbrogli
approved these changes
Jul 18, 2024
jansegre
force-pushed
the
fix/version-logging
branch
from
396f3cd to
eb74c11
Compare
This was referenced Jul 25, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Different version log is unnecessarily a warning.
Acceptance Criteria
log.warntolog.debug.Checklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged