Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1062 +/- ##
=======================================
Coverage 84.95% 84.96%
=======================================
Files 300 300
Lines 22944 22944
Branches 3471 3471
=======================================
+ Hits 19493 19494 +1
+ Misses 2767 2764 -3
- Partials 684 686 +2 ☔ View full report in Codecov by Sentry. |
msbrogli
approved these changes
Jun 11, 2024
glevco
approved these changes
Jun 11, 2024
This was referenced Jul 25, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
We've had some partial support for PyPy that never took off, there are no known cases using PyPy for either production or even experimenting. Although our initial tests a long time ago have shown significant performance improvements over the best Python version at the time, it never ended up being used and lack of maintenance meant even the current docker build is not working. Also, the PyPy project's support for Python compatibility doesn't move quickly enough, we might start deprecating Python 3.10 support soon (so we can use Python 3.11 features) but PyPy supports at most Python 3.10 (and support for 3.11 hasn't even started).
Acceptance Criteria
Dockerfile.pypy)Makefile(shortcut to build the docker image)Checklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged