Skip to content

feat(side-dag): implement Proof-of-Authority#1060

Merged
glevco merged 1 commit intomasterfrom
feat/side-dag/poa
Jul 8, 2024
Merged

feat(side-dag): implement Proof-of-Authority#1060
glevco merged 1 commit intomasterfrom
feat/side-dag/poa

Conversation

@glevco
Copy link
Contributor

@glevco glevco commented Jun 11, 2024

Motivation

Implement Proof-of-Authority block, verification, and related configuration.

Acceptance Criteria

  • Add new VertexVerifier.verify_version().
  • Add CONSENSUS_ALGORITHM settings. When PROOF_OF_AUTHORITY is set:
    • Disable mining WebSocket.
    • Enable PoaBlock and disable Block and MergeMinedBlock.
    • Disable TransactionVerifier.verify_weight().
  • Implement get_hashed_poa_data() and sign_poa().
  • Implement PoaBlockVerifier.verify_poa().

Checklist

  • If you are requesting a merge into master, confirm this code is production-ready and can be included in future releases as soon as it gets merged

@glevco glevco self-assigned this Jun 11, 2024
@codecov
Copy link

codecov bot commented Jun 11, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 36 lines in your changes missing coverage. Please review.

Project coverage is 84.91%. Comparing base (c075d5e) to head (701491c).

Files Patch % Lines
hathor/verification/verification_service.py 50.00% 10 Missing and 5 partials ⚠️
hathor/transaction/poa/poa_block.py 72.41% 4 Missing and 4 partials ⚠️
hathor/consensus/poa/poa_signer.py 92.45% 2 Missing and 2 partials ⚠️
hathor/transaction/base_transaction.py 60.00% 1 Missing and 1 partial ⚠️
hathor/verification/poa_block_verifier.py 95.23% 2 Missing ⚠️
hathor/verification/vertex_verifier.py 50.00% 1 Missing and 1 partial ⚠️
hathor/builder/resources_builder.py 66.66% 0 Missing and 1 partial ⚠️
hathor/conf/get_settings.py 80.00% 1 Missing ⚠️
hathor/consensus/consensus_settings.py 97.29% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1060      +/-   ##
==========================================
+ Coverage   84.82%   84.91%   +0.08%     
==========================================
  Files         300      307       +7     
  Lines       22936    23173     +237     
  Branches     3471     3503      +32     
==========================================
+ Hits        19456    19677     +221     
- Misses       2787     2793       +6     
- Partials      693      703      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@glevco glevco force-pushed the feat/side-dag/poa branch from 9b79f2e to d8b4f9c Compare June 11, 2024 15:25
@glevco glevco marked this pull request as ready for review June 11, 2024 16:04
@glevco glevco requested review from jansegre and msbrogli as code owners June 11, 2024 16:04
@glevco glevco marked this pull request as draft June 11, 2024 16:21
@glevco glevco force-pushed the feat/side-dag/poa branch from d8b4f9c to c18954f Compare June 11, 2024 18:30
@glevco glevco marked this pull request as ready for review June 11, 2024 18:54
jansegre
jansegre previously approved these changes Jun 12, 2024
jansegre
jansegre previously approved these changes Jun 17, 2024
@glevco glevco force-pushed the feat/side-dag/poa branch from 8985bae to 4e359f5 Compare June 20, 2024 13:38
@glevco glevco force-pushed the feat/side-dag/poa branch from 4e359f5 to c8b6ed1 Compare July 5, 2024 17:56
@glevco glevco force-pushed the feat/side-dag/poa branch from c8b6ed1 to 701491c Compare July 8, 2024 14:25
@glevco glevco merged commit f95d189 into master Jul 8, 2024
@glevco glevco deleted the feat/side-dag/poa branch July 8, 2024 15:11
This was referenced Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants