refactor(p2p): split hathor.p2p.peer_discovery into separate modules#1055
Merged
refactor(p2p): split hathor.p2p.peer_discovery into separate modules#1055
Conversation
glevco
approved these changes
Jun 6, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1055 +/- ##
==========================================
+ Coverage 84.92% 84.99% +0.07%
==========================================
Files 297 300 +3
Lines 22932 22943 +11
Branches 3470 3470
==========================================
+ Hits 19475 19501 +26
+ Misses 2770 2760 -10
+ Partials 687 682 -5 ☔ View full report in Codecov by Sentry. |
msbrogli
approved these changes
Jun 6, 2024
This was referenced Jul 25, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The
hathor.p2p.peer_discoverymodule aggregates the abstraction and implementations, it could be split to make future implementations cleaner to review.Acceptance Criteria
hathor.p2p.peer_discoveryinto the following submodules:peer_discovery(abstraction),dns(DNS implementation),bootstrap(bootstrap implementation), expose everything the same way they were being exposed before.Checklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged