fix(resources): regression in address history endpoint#1042
Merged
Conversation
msbrogli
reviewed
May 28, 2024
msbrogli
approved these changes
May 28, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1042 +/- ##
==========================================
- Coverage 84.89% 84.83% -0.06%
==========================================
Files 297 297
Lines 22910 22914 +4
Branches 3464 3465 +1
==========================================
- Hits 19449 19439 -10
- Misses 2775 2783 +8
- Partials 686 692 +6 ☔ View full report in Codecov by Sentry. |
msbrogli
previously approved these changes
May 28, 2024
pedroferreira1
previously approved these changes
May 28, 2024
43eaefb to
749dfc1
Compare
msbrogli
approved these changes
May 28, 2024
pedroferreira1
approved these changes
May 28, 2024
749dfc1 to
97cb18e
Compare
This was referenced May 28, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
After the release o v0.60.0 a bug was reported in the address-history API. The bug was introduced after the optimizations in #978, reverting the PR makes the bug disappear.
Acceptance Criteria
Checklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged