Skip to content

Refactor/metadata/migrate feature states 3#1015

Closed
glevco wants to merge 1 commit intorefactor/metadata/migrate-static-metadata-2from
refactor/metadata/migrate-feature-states-3
Closed

Refactor/metadata/migrate feature states 3#1015
glevco wants to merge 1 commit intorefactor/metadata/migrate-static-metadata-2from
refactor/metadata/migrate-feature-states-3

Conversation

@glevco
Copy link
Contributor

@glevco glevco commented May 1, 2024

Depends on #1014

Motivation

What was the motivation for the changes in this PR?

Acceptance Criteria

  • Include here all things that this PR should solve

Checklist

  • If you are requesting a merge into master, confirm this code is production-ready and can be included in future releases as soon as it gets merged

@glevco glevco added the refactor label May 1, 2024
@glevco glevco self-assigned this May 1, 2024
@glevco glevco force-pushed the refactor/metadata/migrate-feature-states-3 branch 2 times, most recently from 4741573 to 223185c Compare May 1, 2024 20:47
@glevco glevco force-pushed the refactor/metadata/migrate-static-metadata-2 branch 2 times, most recently from 942358a to 3912750 Compare May 2, 2024 15:57
@glevco glevco force-pushed the refactor/metadata/migrate-feature-states-3 branch 3 times, most recently from 7e353fc to 648d0a3 Compare May 2, 2024 20:25
@glevco glevco force-pushed the refactor/metadata/migrate-static-metadata-2 branch from 3912750 to 1372d65 Compare May 2, 2024 21:08
@glevco glevco force-pushed the refactor/metadata/migrate-feature-states-3 branch 8 times, most recently from 1e13b1e to 0d2fa76 Compare May 3, 2024 00:28
@codecov
Copy link

codecov bot commented May 3, 2024

Codecov Report

Attention: Patch coverage is 88.62275% with 19 lines in your changes are missing coverage. Please review.

Project coverage is 84.76%. Comparing base (9e960f7) to head (09c8c5d).

Files Patch % Lines
...ction/storage/migrations/migrate_feature_states.py 52.00% 12 Missing ⚠️
hathor/vertex_handler/vertex_handler.py 50.00% 3 Missing and 1 partial ⚠️
...on/storage/migrations/remove_first_nop_features.py 0.00% 1 Missing ⚠️
...n/storage/migrations/remove_second_nop_features.py 0.00% 1 Missing ⚠️
hathor/verification/block_verifier.py 80.00% 1 Missing ⚠️
Additional details and impacted files
@@                               Coverage Diff                               @@
##           refactor/metadata/migrate-static-metadata-2    #1015      +/-   ##
===============================================================================
+ Coverage                                        84.71%   84.76%   +0.05%     
===============================================================================
  Files                                              300      301       +1     
  Lines                                            23122    23078      -44     
  Branches                                          3503     3489      -14     
===============================================================================
- Hits                                             19587    19562      -25     
+ Misses                                            2859     2843      -16     
+ Partials                                           676      673       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@glevco glevco force-pushed the refactor/metadata/migrate-static-metadata-2 branch from 1372d65 to 9e960f7 Compare May 3, 2024 01:16
@glevco glevco force-pushed the refactor/metadata/migrate-feature-states-3 branch from 0d2fa76 to 17ba8de Compare May 3, 2024 01:20
@glevco
Copy link
Contributor Author

glevco commented May 3, 2024

This PR was broken into PRs #1016, #1017, and #1018.

@glevco glevco closed this May 3, 2024
@glevco glevco deleted the refactor/metadata/migrate-feature-states-3 branch May 3, 2024 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant