Skip to content

Refactor/static metadata#1012

Closed
glevco wants to merge 1 commit intomasterfrom
refactor/static-metadata
Closed

Refactor/static metadata#1012
glevco wants to merge 1 commit intomasterfrom
refactor/static-metadata

Conversation

@glevco
Copy link
Contributor

@glevco glevco commented Apr 30, 2024

Motivation

What was the motivation for the changes in this PR?

Acceptance Criteria

  • Include here all things that this PR should solve

Checklist

  • If you are requesting a merge into master, confirm this code is production-ready and can be included in future releases as soon as it gets merged

@glevco glevco self-assigned this Apr 30, 2024
@glevco glevco force-pushed the refactor/static-metadata branch 5 times, most recently from 8d098b7 to b682d12 Compare May 1, 2024 02:54
@codecov
Copy link

codecov bot commented May 1, 2024

Codecov Report

Attention: Patch coverage is 90.41096% with 28 lines in your changes are missing coverage. Please review.

Project coverage is 84.73%. Comparing base (e06d1d4) to head (cb4c721).

Files Patch % Lines
...tion/storage/migrations/migrate_static_metadata.py 41.66% 21 Missing ⚠️
hathor/transaction/storage/rocksdb_storage.py 80.00% 4 Missing ⚠️
hathor/mining/block_template.py 0.00% 1 Missing ⚠️
hathor/transaction/base_transaction.py 94.73% 0 Missing and 1 partial ⚠️
hathor/transaction/storage/cache_storage.py 91.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1012      +/-   ##
==========================================
- Coverage   84.99%   84.73%   -0.27%     
==========================================
  Files         298      300       +2     
  Lines       22952    23101     +149     
  Branches     3466     3503      +37     
==========================================
+ Hits        19509    19575      +66     
- Misses       2761     2852      +91     
+ Partials      682      674       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@glevco glevco force-pushed the refactor/static-metadata branch from b682d12 to cb4c721 Compare May 1, 2024 04:12
@glevco
Copy link
Contributor Author

glevco commented May 2, 2024

Moved to PRs #1013 and #1014.

@glevco glevco closed this May 2, 2024
@glevco glevco deleted the refactor/static-metadata branch May 2, 2024 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant