Conversation
jansegre
approved these changes
Apr 25, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1007 +/- ##
==========================================
+ Coverage 84.85% 84.87% +0.02%
==========================================
Files 296 296
Lines 22872 22875 +3
Branches 3460 3460
==========================================
+ Hits 19407 19415 +8
+ Misses 2774 2771 -3
+ Partials 691 689 -2 ☔ View full report in Codecov by Sentry. |
msbrogli
approved these changes
Apr 25, 2024
This was referenced May 2, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
There is a bug in the
p2p.reload_entrypoints_and_connectionssysctl command, because thePeerId.source_fileis not being set.Acceptance Criteria
PeerId.source_fileproperty.Checklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged