refactor(api): prevent duplicate tx earlier#1006
Merged
Conversation
8f29b24 to
838e337
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1006 +/- ##
==========================================
+ Coverage 84.87% 84.90% +0.03%
==========================================
Files 300 300
Lines 22943 22945 +2
Branches 3470 3471 +1
==========================================
+ Hits 19473 19482 +9
+ Misses 2778 2774 -4
+ Partials 692 689 -3 ☔ View full report in Codecov by Sentry. |
838e337 to
c60ec93
Compare
glevco
approved these changes
May 7, 2024
c60ec93 to
f70cdef
Compare
msbrogli
approved these changes
Jul 24, 2024
f70cdef to
e6c68da
Compare
This was referenced Jul 25, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This verification has to happen anyway and doing it earlier avoids wasting time with more expensive verifications.
Acceptance Criteria
HathorManager.push_txdirectly before waiting forHathorManger.on_new_txto do it.Checklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged