feat: add first_block to the to_json_extended method of base transaction class#1003
Merged
feat: add first_block to the to_json_extended method of base transaction class#1003
Conversation
b1cd692 to
3f3c5a0
Compare
b0e3807 to
f87d8bd
Compare
jansegre
approved these changes
Apr 19, 2024
pedroferreira1
approved these changes
Apr 19, 2024
f87d8bd to
edfdb1a
Compare
msbrogli
approved these changes
Apr 24, 2024
edfdb1a to
cbd4c2d
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1003 +/- ##
==========================================
- Coverage 84.92% 84.90% -0.03%
==========================================
Files 298 298
Lines 22925 22928 +3
Branches 3463 3464 +1
==========================================
- Hits 19470 19467 -3
- Misses 2768 2771 +3
- Partials 687 690 +3 ☔ View full report in Codecov by Sentry. |
This was referenced May 2, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Wallet Mobile needs the ability to show a nano contract transaction "status" in the token's transaction details modal, but this "status" requires to know if a nano contract transaction was already confirmed by a block of not, thus the
first_blockas a first citizen of a transaction.Acceptance Criteria
first_blockto theto_json_extendedto BaseTransaction for transactions./dashboard_tx/transaction/thin_wallet/address_history/thin_wallet/token_historyChecklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged