Skip to content

Conversation

@Apoorve73
Copy link

Overview

Update Queries for Robocon page, to fetch data from Cloud Firestore instead of Real Time Database.

Copy link
Owner

@HashirGJ8842 HashirGJ8842 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work

}

export const db = firebase.database()
export const firestoreDb = firebase.firestore()
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rename this variable as DB, this would be the name everyone will proceed with

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure!

@HashirGJ8842
Copy link
Owner

And update this branch to resolve conflicts.

@Apoorve73
Copy link
Author

I have resolved conflicts and have also made the required changes. Please check now, @HashirGJ8842
Thanks!

Copy link
Owner

@HashirGJ8842 HashirGJ8842 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@HashirGJ8842 HashirGJ8842 changed the title Robocon db migrate chore : Migrate Robocon section to firestore Mar 6, 2021
@HashirGJ8842 HashirGJ8842 merged commit e01d30a into HashirGJ8842:migrate Mar 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants