Add HUIT cost allocation tags #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arthurian
reviewed
Jan 7, 2019
arthurian
reviewed
Jan 7, 2019
launch_cluster/launch.py
Outdated
| @@ -71,6 +71,9 @@ def launch_manager(config): | |||
| {"Key": "Owner", "Value": config.server_owner}, | |||
| {"Key": "Creator", "Value": config.server_owner}, | |||
| {"Key": "Jupyter Cluster", "Value": config.cluster_name}, | |||
| {"Key": "platform", "Value": "linux"}, | |||
| {"Key": "environment", "Value": "production"}, | |||
There was a problem hiding this comment.
Same comment with respect to the spawner.py (optional param with a default).
|
@joshuagetega Looks good! My only comment is that we've hard-coded the environment tag to "production" which would preclude us from allocating costs to any "development" or "sandbox" clusters based on the tag. This also applies to the changes you made to the volume/snapshot tagging in our gitlab repo. I don't see this as a blocker, just something that we might want to address for maximum flexibility down the line. |
Tag manager and workers with 'platform', 'product', and 'environment' tags. These are required by HUIT, as specified in https://confluence.huit.harvard.edu/display/CLA/Cloud+Resource+Tagging#CloudResourceTagging-4.5%22platform%22Tag, for cost allocation.
|
I have parameterized the tags and provided defaults. Merging ... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tag manager and workers with 'platform', 'product', and 'environment' tags. These are required by HUIT, as specified here, for cost allocation. This change has been tested - see the tags of the manager and worker instance in the 'test-tagging' cluster. (The tagging of volumes and snapshots is
not implemented here but in a separate PR in our gitlab jupyterhub repo). Let me know if you have any thoughts. Otherwise a thumbs up review is good enough here :).