Refactor launch script with fabric upgrade changes #10
Conversation
|
Please note, there is one more (tiny) piece to this fabric upgrade. Namely, including the package in the userdata section of the Cloudformation template that spins up the launcher ec2 instance. I have created an issue for that as opposed to editing the template right away. This is because there are new Cloudformation templates in the upstream CloudJHub repository, so those will have to be pulled in first. I will create a new story for getting our fork and the upstream CloudJHub repository aligned (pushing up changes we've made in our fork and pulling in upstream changes). At any rate, I already installed the fabric2 package in the current launcher ec2 instance. |
There was a problem hiding this comment.
Looks good, @joshuagetega ! I would just verify the indentation where I commented.
joshuagetega
force-pushed
the
fabric-upgrade-pt2
branch
from
5052c53 to
787fd63
Compare
There was a problem hiding this comment.
Just one or two questions, but otherwise looks good @joshuagetega! 👍
This PR refactors the script that launches a jupyterhub cluster with changes that come with the fabric upgrade. Details on the fabric upgrade can be found in a related PR here.
I have tested the changes and verified successful launch of a cluster.