Stabilize WAL snapshot integration test by aligning walLsn expectation with API contract - #46
Merged
Conversation
Copilot created this pull request from a session on behalf of
HarryCordewener
July 27, 2026 03:02
View session
HarryCordewener
marked this pull request as ready for review
July 27, 2026 03:03
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI was failing in
integration (http + ffi)due to a flaky assertion inWalDatabase_SnapshotSaveAndLoad_RestoresWalState. The test expectedwalLsnon snapshot save metadata, but snapshot save/load responses may legitimately returnnullfor that field.Contract mismatch in WAL snapshot test
EmbeddedWalPersistenceIntegrationTeststo assertsaved.WalLsnisnullfor snapshot save metadata.Behavioral impact