rework assignable tunic/boots to use shipinit and hooks #4978
+116
−47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
briaguya-ai
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
moved the rabbit hole diving i was doing in #4977 over here
main issue is that having
VB_ITEM_ACTION_BE_NONEdo the tunic/boots safeguarding conditionally on assignable tunic/boots makes it so unchecking that while still having tunic/boots equipped then trying to use them by pressing the button causes a crash, i haven't started digging into how to handle that with hooks yet(done in bfc3679)there's also the kaleido part of the rabbit hole which i don't plan on getting to in this PR
Build Artifacts