Add safety measure to Scene_CommandObjectList to prevent crash

[inspectredc]

On debug versions it was reported that going between certain rooms in a scene would cause a crash. I gave this branch for someone to test and it seems to fix the issue. I believe what was happening was just that cmdObj->objects[k] was indexing past the size of objects, however, I was never able to replicate the original crash on my machine

Build Artifacts

• soh.otr.zip
• soh-linux-compatibility.zip
• soh-linux-performance.zip
• soh-mac.zip
• soh-switch.zip
• soh-wiiu.zip
• soh-windows.zip

[Archez]

Comparing this against the original code with the while loops, I think this is missing something.

Shipwright/soh/src/code/z_scene.c

Lines 264 to 289 in be8dcfd

	s16* objectEntry = SEGMENTED_TO_VIRTUAL(cmd->objectList.segment);
	void* nextPtr;
	k = 0;
	i = play->objectCtx.unk_09;
	firstStatus = &play->objectCtx.status[0];
	status = &play->objectCtx.status[i];
	while (i < play->objectCtx.num) {
	if (status->id != *objectEntry) {
	status2 = &play->objectCtx.status[i];
	for (j = i; j < play->objectCtx.num; j++) {
	status2->id = OBJECT_INVALID;
	status2++;
	}
	play->objectCtx.num = i;
	func_80031A28(play, &play->actorCtx);
	continue;
	}
	i++;
	k++;
	objectEntry++;
	status++;
	}

From here I interpret that the if (status->id != *objectEntry) handles when play->objectCtx.num is larger than the amount of objects to be loaded by the command. Then it basically invalidates all the extra objects and calls the actor kill all func.

With how the for loop is written/with your change, it seems like the invalidate/actor kill all wont run if cmdObj->objects.size() is smaller than play->objectCtx.num.

I think we need to re-work this for loop to handle that condition. I've provided a suggestion below that I think works.

[inspectredc]

Thanks for the suggestion! Definitely makes sense that way and matches the behaviour I expect from the function. I hadn't thought about needing to clear the remaining slots in the bank to match the original behaviour, so this is good, thank you!