Fix Fire Temple Boss Door Logic #3774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Archez
approved these changes
Dec 30, 2023
soh/soh/Enhancements/randomizer/3drando/location_access/locacc_fire_temple.cpp
Outdated
Show resolved
Hide resolved
…_fire_temple.cpp Co-authored-by: Adam Bird <[email protected]>
briaguya-ai
approved these changes
Jan 5, 2024
There was a problem hiding this comment.
took a bit to understand the diff (i was confused about the hovers part) but i think i get it now
before:
Entrance(FIRE_TEMPLE_BOSS_ENTRYWAY, {[]{
return BossKeyFireTemple && (
(IsAdult && LogicFireBossDoorJump) ||
CanUse(HOVER_BOOTS) ||
Here(FIRE_TEMPLE_FIRE_MAZE_UPPER, []{return CanUse(MEGATON_HAMMER);})
);
}}),after:
Entrance(FIRE_TEMPLE_BOSS_ENTRYWAY, {[]{
return BossKeyFireTemple && (
(IsAdult && (
LogicFireBossDoorJump ||
Here(FIRE_TEMPLE_FIRE_MAZE_UPPER, []{return CanUse(MEGATON_HAMMER);})
)) ||
CanUse(HOVER_BOOTS));
}}),
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only adult can reach the boss door once this block is lowered. This adds a check for that
Build Artifacts