Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Condition causing enemies to always be small in enemy size rando #3512

Merged
merged 1 commit into from
Dec 17, 2023
Merged

Fix: Condition causing enemies to always be small in enemy size rando #3512

merged 1 commit into from
Dec 17, 2023

Conversation

Archez
Copy link
Contributor

@Archez Archez commented Dec 11, 2023 •
edited
Loading

After #3452 enemies were only ever small. Problem was the smallOnlyEnemy condition was evaluating to just the Deadhand ID, rather than a check against it to the current actor ID, due to a missing actor->id ==. This fixes the condition so that enemies can be big again.

Build Artifacts

aMannus
aMannus approved these changes Dec 11, 2023
View reviewed changes
Copy link
Contributor

@aMannus aMannus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a baguette and a half for me.. thought I tested this, oof. Thank you Archez.

@briaguya-ai briaguya-ai merged commit e2f1ceb into HarbourMasters:develop-macready Dec 17, 2023
8 checks passed
@Archez Archez deleted the fix-enemy-sizes-always-small branch December 17, 2023 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briaguya-ai briaguya-ai briaguya-ai approved these changes

@aMannus aMannus aMannus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Archez @aMannus @briaguya-ai