Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate Arrows Equip Dupe Fix #3450

Conversation

inspectredc
Copy link
Contributor

@inspectredc inspectredc commented Nov 26, 2023

The behaviour of equip dupe was being emulated when the enhancement for having separated magic arrow equips was on. This just adds a check in the code where equip dupe happens to make sure this enhancement is not turned on. see here for an example of what this looks like

Build Artifacts

@inspectredc inspectredc changed the base branch from develop to develop-macready November 27, 2023 00:00
@Archez
Copy link
Contributor

Archez commented Nov 27, 2023

I'm not familiar enough with equip dupe. Could you explain what exactly is happening now if that bow enhancement is on?

  • Is all of equip dupe disabled?
  • Is only equip duping over bow related items disabled?

@inspectredc
Copy link
Contributor Author

I'm not familiar enough with equip dupe. Could you explain what exactly is happening now if that bow enhancement is on?

* Is all of equip dupe disabled?

* Is only equip duping over bow related items disabled?

Equip dupe is a glitch that only works as a result of an additional 'swap condition' check that the developers did when you have a bow as the target item of your equip. Basically you have your target equip slot A which currently has any item e.g. hammer on that slot. Then when you equip bow (and specifically only bow) onto that slot, it will check every slot which has any magic arrow equipped, and place hammer onto those slots, and then equip bow onto your target slot.

To answer the bullet points:

  • equip dupe does not work with this enhancement enabled as a result
  • equip dupe is a glitch arising from bow items anyway, although any item can be duped into multiple slots by being in the equip target slot

@Archez
Copy link
Contributor

Archez commented Nov 27, 2023

Ok I see. Might want to update the tooltip for the enhancement indicating that it will disable that type of equip dupe then.

@aMannus
Copy link
Contributor

aMannus commented Nov 27, 2023

Ok I see. Might want to update the tooltip for the enhancement indicating that it will disable that type of equip dupe then.

Agreed. Something like "This enhancement will prevent the equip dupe glitch from working" would be nice to have.

@aMannus aMannus merged commit 9d215b6 into HarbourMasters:develop-macready Nov 28, 2023
8 checks passed
A-Green-Spoon pushed a commit to A-Green-Spoon/Shipwright that referenced this pull request Nov 30, 2023
* add gseparatearrow check for equip dupe fix

* update gseparatearrows tooltip
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants