[Fix] Crash from Tracker on Transferred Saves #3368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ock to load the "trackerData" section to a new `OnLoadGame` hook function to fix crashes on transferred saves.
briaguya-ai
approved these changes
Nov 12, 2023
Archez
approved these changes
Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When transferring vanilla saves, the "trackerData" section didn't exist, and thus wouldn't run
RandomizerCheckTracker::LoadFile(), which had some critical initialization routines. This would cause a crash any time you tried to collect an item (or if you saved once first, would crash once, then be fine afterward). That function shouldn't have done anything but load the "trackerData" section in the first place. This moves everything but the "trackerData" block to a newOnLoadGamehook function where it can still guarantee all relevant information for initialization is present, but will be done regardless of if the section originally exists.Build Artifacts