Sync asset names with decomp documentation #3153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Archez
force-pushed
the
sync-assets-decomp
branch
from
0978a68 to
60959fe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a continuation of #3093 and syncs more asset names from decomp, including animations/limbs/skels.
This was done by using a scripted processes to cross reference the XMLs from decomp and the MQ Debug XMLs in SoH. Anything not matching has been updated with the name from decomp. This includes naming things that never have human friendly names, and updating existing human friendly names based on changes in decomp since we forked.
I've left out one part which was the naming of player animation data, as we have a string builder to derive the OTR path name from a segmented address. This will require an actual code change to implement correctly, so I'll save that for a follow up PR.
The script is located here, I leveraged Python (python3) to do the xml comparison and the source code find&replace for names found. The script is quite slow when replacing, but I didn't do much to try to make it more performant.
JSON list of the replaced names (keys are the old names, values are the new names), for anyone needing to script out updates for mods.
synced-names.txt
Build Artifacts