Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add scene table #3131

Merged
merged 4 commits into from
Sep 1, 2023
Merged

Add scene table #3131

merged 4 commits into from
Sep 1, 2023

Conversation

Pepe20129
Copy link
Contributor

@Pepe20129 Pepe20129 commented Aug 19, 2023 •
edited by github-actions bot
Loading

Adds the scene table from decomp and renames every scene.

Needs a lot of testing to make sure I made no mistakes.

Build Artifacts

garrettjoecox
garrettjoecox approved these changes Aug 20, 2023
View reviewed changes
Copy link
Contributor

@garrettjoecox garrettjoecox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified with a script that this hits all places with the exception of soh/soh/CrashHandlerExt.cpp, minor but we'll want to update that too 👍

Just one other question from me, aside from that LGTM

soh/src/code/z_parameter.c Show resolved Hide resolved
@Pepe20129
Copy link
Contributor Author

Is there a reason CrashHandlerExt.cpp doesn't include debug-only scenes?

@garrettjoecox
Copy link
Contributor

Is there a reason CrashHandlerExt.cpp doesn't include debug-only scenes?

Likely just an oversight. Feel free to add them

@Pepe20129
Copy link
Contributor Author

Done.

@garrettjoecox garrettjoecox merged commit 45b7520 into HarbourMasters:develop Sep 1, 2023
@Pepe20129 Pepe20129 deleted the scene_table branch September 1, 2023 17:26
@Archez Archez mentioned this pull request Sep 15, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@garrettjoecox garrettjoecox garrettjoecox approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Pepe20129 @garrettjoecox