-
Notifications
You must be signed in to change notification settings - Fork 516
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix various randomiser text issues and related improvments. #3066
Fix various randomiser text issues and related improvments. #3066
Conversation
I wanted to discuss the renaming of the junk items, particularly those in French, I'm uncertain about the source of these name changes, whether they originated from the OOT3D randomizer or were your own decisions I also want to mention that upon further review, it became evident that my concerns extend beyond just the French renaming. I noticed that many of the modifications replaced references to past games or elements that added depth to the player's decisions. Instead, they were changed to more obvious or unrelated names. In my opinion, these alterations appear unnecessary and may have removed the meaningful connections and attention-grabbing aspects of the original names. It seems that several modifications have replaced valuable references to past games or elements that enhanced the gameplay experience. These changes have now resulted in names that are more straightforward or unrelated, which, in my view, was not necessary. I hope this revised message captures the essence of your original concerns while presenting them in a more considerate manner. If there's anything else I can assist you with or if you have any specific suggestions for alternative names for the junk items, please let me know. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looooong and massive change, please don't hate me ^-^
@@ -225,19 +225,19 @@ void InitTrickNames() { | |||
trickNameTable[GI_SWORD_KOKIRI] = { | |||
Text{"Korok Sword", "Épée Korok", "Espada Korok"}, | |||
Text{"Hero's Sword", "Épée du Héros", "Espada del héroe"}, | |||
Text{"Razor Sword", "Lame Rasoir", "Espada de esmeril"}}; | |||
Text{"Butter Knife","couteau à beurre","cuchillo de mantequilla"}}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couteau à Beurre
Text{"Big Goron's Sword", "Épée de Gros Goron", "Espada de Big Goron"}, | ||
Text{"Fierce Deity's Sword", "Épée du Dieu Démon", "Espada de la Fiera Deidad"}, | ||
Text{"Biggoron's Knife", "Lame de Grogoron", "Daga de Biggoron"}}; | ||
Text{"Medigoron's Sword", "L'épée de Medigoron", "La espada de Medigoron"}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
l'Épée de Medigoron
Text{"Biggoron's Knife", "Lame de Grogoron", "Daga de Biggoron"}}; | ||
Text{"Medigoron's Sword", "L'épée de Medigoron", "La espada de Medigoron"}, | ||
Text{"Razor Sword", "Lame Rasoir", "Espada de esmeril"}, | ||
Text{"Royal Claymore", "Royal Claymore", "Royal Claymore"}}; //machine translation failed? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Claymore Royale
Text{"Big Goron's Sword", "Épée de Biggoron", "Espada de Big Goron"}, | ||
Text{"Fierce Deity's Sword", "Épée du dieu démon", "Espada de la Fiera Deidad"}, | ||
Text{"Biggoron's Knife", "Lame de Grogoron", "Daga de Biggoron"}}; | ||
Text{"Power Sword", "Épée de puissance", "Espada de poder"}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Épée de Puissance
Text{"Biggoron's Knife", "Lame de Grogoron", "Daga de Biggoron"}}; | ||
Text{"Power Sword", "Épée de puissance", "Espada de poder"}, | ||
Text{"Fierce Deity Sword", "Épée du dieu démon", "Espada de la Fiera Deidad"}, | ||
Text{"Tempered Sword", "Épée de légende niv. 2", "Espada Maestra mejorada"}}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Épée de Légende Nv.2
Text{"Bottle with Small Jabu-Jabu", "Flacon avec mini Jabu-Jabu", "Lord Chapu-Chapu embotellado"}, | ||
Text{"Bottle with Reekfish", "Flacon avec Reekfish", "Reekfish embotellada"}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the TP ref;; but the original one was better about an obscure cut content about MM and a mini jabu jabu on a bottle
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did not know about that reference, thought it was just a joke, my bad
Text{"Bottle with Imp Poe", "Flacon avec Spectre", "Espectro en una botella"}, | ||
Text{"Bottle with Reapling", "Flacon avec Âme Damnée", "Reapling en una botella"}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The old one feels better at least in french
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quite possibly, I warned people at the start i had no idea what I was doing with the other languages.
Text{"Bolero of Fire", "Boléro du feu", "Bolero del fuego"}}; | ||
Text{"Song of the Hero", "Chant du héros", "Canción del héroe"}}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Old was forcing the player to pay attention on the GI item and not the title
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, and fixing that is a major motivation of these changes, as these names are used for scrubs and merchant hints too, which do not have graphics.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed with @Pepper0ni here, if it was just the shops then the real song names on the wrong song would be fine but the situations where you can't see the actual item do make the real song names a bit unfair.
Text{"Song of Passing", "Mambo de Manbo", "Melodía del transcurrir"}, | ||
Text{"Command Melody", "Air du marionnettiste", "Cara al Sol"}, | ||
Text{"Prelude of Light", "Prélude de la lumière", "Preludio de la luz"}}; | ||
Text{"Moon's Song", "La chanson de Moon", "La canción de la luna"}}; | ||
trickNameTable[0xC5] = { | ||
Text{"Song of Double Time", "Chant accéléré", "Canción del doble tiempo"}, | ||
Text{"Inverted Song of Time", "Chant du temps inversé", "Canción del tiempo invertida"}, | ||
Text{"Serenade of Water", "Sérénade de l'eau", "Serenata del agua"}}; | ||
Text{"Tune of Ages", "Chant du Temps", "Melodía del Tiempo"}}; | ||
trickNameTable[0xC6] = { | ||
Text{"Ballad of Gales", "Requiem de la tornade", "Melodía del Tornado"}, | ||
Text{"Frog's Song of Soul", "Rap des grenouilles", "Canción del alma de la rana"}, | ||
Text{"Nocturne of Shadow", "Nocturne de l'ombre", "Nocturno de la sombra"}}; | ||
Text{"Wind's Requiem", "Mélodie du vent", "Melodía del Viento"}}; | ||
trickNameTable[0xBB] = { | ||
Text{"Saria's Karaoke", "Karaoké de Saria", "Dueto del bosque"}, | ||
Text{"Sonata of Awakening", "Sonate de l'éveil", "Sonata del despertar"}, | ||
Text{"Saria's Song", "Chant de Saria", "Canción de Saria"}}; | ||
Text{"Wind God's Aria", "Hymne du dieu du vent", "Melodía del Espíritu del Viento"}}; | ||
trickNameTable[0xBC] = { | ||
Text{"Darunia's Tango", "Tango de Darunia", "Coro del fuego"}, | ||
Text{"Goron Lullaby", "Berceuse des Gorons", "Nana goron"}, | ||
Text{"Zelda's Lullaby", "Berceuse de Zelda", "Nana de Zelda"}}; | ||
Text{"Tune of Currents", "Chants des Flux", "Melodía de las Corrientes"}, | ||
Text{"Goron Lullaby", "Berceuse des Gorons", "Nana goron"}}; | ||
trickNameTable[0xBD] = { | ||
Text{"Ruto's Blues", "Blues de Ruto", "Sonata del agua"}, | ||
Text{"New Wave Bossa Nova", "Bossa-nova des flots", "Bossanova de las olas"}, | ||
Text{"Song of Time", "Chant du temps", "Canción del tiempo"}}; | ||
Text{"Manbo's Mambo", "Mambo de Manbo", "Mambo de Manbo"}}; | ||
trickNameTable[0xBE] = { | ||
Text{"Nabooru's Reggae", "Reggae de Nabooru", "Reggae del espíritu"}, | ||
Text{"Elegy of Emptiness", "Hymne du vide", "Elegía al vacío"}, | ||
Text{"Epona's Song", "Chant d'Épona", "Canción de Epona"}}; | ||
Text{"Earth God's Lyric", "Hymne du dieu de la terre", "Melodía del Espíritu de la Tierra"}}; | ||
trickNameTable[0xBF] = { | ||
Text{"Impa's Death Metal", "Death métal d'Impa", "Diurno de la sombra"}, | ||
Text{"Oath to Order", "Ode de l'appel", "Oda al orden"}, | ||
Text{"Song of Storms", "Chant des tempêtes", "Canción de la tormenta"}}; | ||
Text{"Song of Discovery", "Chant des secrets", "Canto revelador"}}; | ||
trickNameTable[0xC0] = { | ||
Text{"Rauru's Sing-Along", "Chansonnette de Rauru", "Predulio de luz"}, | ||
Text{"Ballad of the Wind Fish", "Ballade sur Poisson-Rêve", "Balada del Piez Viento"}, | ||
Text{"Sun's Song", "Chant du soleil", "Canción del Sol"}}; | ||
Text{"Song of Light", "Chant de la lumière", "Sonidos de la luz"}}; | ||
|
||
trickNameTable[0xCB] = { | ||
Text{"Pendant of Courage", "Pendentif du courage", "Colgante del valor"}, | ||
Text{"Farore's Emerald", "Émeraude de Farore", "Esmeralda de Farore"}, | ||
Text{"Kokiri's Peridot", "Péridot Kokiri", "Ágata de los Kokiri"}}; | ||
Text{"Farore's Pearl", "Perle de Farore", "Orbe de Farore"}, | ||
Text{"Aquanine", "Smaragdine", "Yerbánida"}}; | ||
trickNameTable[0xCC] = { | ||
Text{"Pendant of Power", "Pendentif de la force", "Colgante del poder"}, | ||
Text{"Din's Ruby", "Rubis de Din", "Rubí de Din"}, | ||
Text{"Goron's Garnet", "Grenat Goron", "Topacio de los Goron"}}; | ||
Text{"Din's Pearl", "Perle de Din", "Orbe de Din"}, | ||
Text{"Crimsonine", "Alzanine", "Bermellina"}}; | ||
trickNameTable[0xCD] = { | ||
Text{"Pendant of Wisdom", "Pendentif de la sagesse", "Colgante de la sabiduría"}, | ||
Text{"Nayru's Sapphire", "Saphir de Nayru", "Zafiro de Nayru"}, | ||
Text{"Zora's Aquamarine", "Aquamarine Zora", "Lapislázuli de los Zora"}}; | ||
Text{"Nayru's Pearl", "Perle de Nayru", "Orbe de Nayru"}, | ||
Text{"Azurine", "Aquanine", "Azurina"}}; | ||
trickNameTable[0xCE] = { | ||
Text{"Wind Medallion", "Médaillon du vent", "Medallón del Viento"}, | ||
Text{"Wind Element", "Elément Vent", "Elemento de aire"}, | ||
Text{"Saria's Medallion", "Médaillon de Saria", "Medallón de Saria"}, | ||
Text{"Medallion of Forest", "Médaillon du Temple de la Forêt", "Medalla del Bosque"}}; | ||
Text{"Sign of Air", "Glyphe de l'air", "Glifo de aire"}}; | ||
trickNameTable[0xCF] = { | ||
Text{"Bombos Medallion", "Médaillon des flammes", "Medallón del Temblor"}, | ||
Text{"Fire Element", "Elément Feu", "Elemento de fuego"}, | ||
Text{"Darunia's Medallion", "Médaillon de Darunia", "Medallón de Darunia"}, | ||
Text{"Medallion of Fire", "Médaillon du Temple du Feu", "Medalla del Fuego"}}; | ||
Text{"Sign of Fire", "Glyphe de feu", "Glifo de fuego"}}; | ||
trickNameTable[0xD0] = { | ||
Text{"Ice Medallion", "Médaillon de glace", "Medallón Helado"}, | ||
Text{"Water Element", "Elément Eau", "Elemento de agua"}, | ||
Text{"Ruto's Medallion", "Médaillon de Ruto", "Medallón de Ruto"}, | ||
Text{"Medallion of Water", "Médaillon du Temple de l'Eau", "Medalla del Agua"}}; | ||
Text{"Sign of Water", "Glyphe de l'eau", "Glifo de agua"}}; | ||
trickNameTable[0xD1] = { | ||
Text{"Quake Medallion", "Médaillon des secousses", "Medallón Llamarada"}, | ||
Text{"Earth Element", "Elément Terre", "Elemento de tierra"}, | ||
Text{"Nabooru's Medallion", "Médaillon de Nabooru", "Medallón de Nabooru"}, | ||
Text{"Medallion of Spirit", "Médaillon du Temple de l'Esprit", "Medalla del Espíritu"}}; | ||
Text{"Sign of Earth", "Glyphe de la Terre", "Glifo de la tierra"}}; | ||
trickNameTable[0xD2] = { | ||
Text{"Travel Medallion", "Amulette de téléportation", "Medallón Maligno"}, | ||
Text{"Fused Shadow", "Cristal d'ombre", "Sombra Fundida"}, | ||
Text{"Impa's Medallion", "Médaillon d'Impa", "Medallón de Impa"}, | ||
Text{"Medallion of Shadow", "Médaillon du Temple de l'Ombre", "Medalla de la Sombra"}}; | ||
Text{"Sign of Illusion", "Glyphe de l'illusion", "Glifo de ilusión"}}; | ||
trickNameTable[0xD3] = { | ||
Text{"Ether Medallion", "Médaillon d'éther", "Medallón de Tesoro"}, | ||
Text{"Compass of Light", "Boussole de lumière", "Brújula de Luz"}, | ||
Text{"Rauru's Medallion", "Médaillon de Rauru", "Medallón de Rauru"}, | ||
Text{"Medallion of Light", "Médaillon du temple de lumière", "Medalla de la Luz"}}; | ||
Text{"Sign of Destiny", "Glyphe du destin", "Glifo del destino"}}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same with all of these, old ones were better references
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As it's not obvious, I'll note here that the Signs are a reference to Zelda's adventure where they are the main quest item.
Text{"Heart Container", "Réceptacle de coeur", "Contenedor de corazón"}, | ||
Text{"Piece of Heart", "Quart de coeur", "Pieza de corazón"}}; | ||
Text{"Life", "Vie", "vida"}, | ||
Text{"HP", "VP", "VP"}}; | ||
trickNameTable[GI_RUPEE_GREEN] = { | ||
Text{"Green Rupy", "Rupee vert", "Rubia verde"}, | ||
Text{"One Rupee", "Un rubis", "Guaraní hyliano"}, | ||
Text{"Rupee (1)", "Rubis (1)", "Peso hyliano"}}; | ||
Text{"False Greg", "Faux Greg", "Falso Greg"}, | ||
Text{"One Ruby", "Un rubis", "Un rubí"}, | ||
Text{"Rupoor (1)", "Roupir (1)", "Rupobre (1)"}}; | ||
trickNameTable[GI_RUPEE_BLUE] = { | ||
Text{"Blue Rupy", "Rupee bleu", "Rubia azul"}, | ||
Text{"Five Rupees", "Cinq rubis", "Bolívar hyliano"}, | ||
Text{"Rupee (5)", "Rubis (5)", "Peso hyliano"}}; | ||
Text{"Blupee", "Bleubi", "Azupia"}, | ||
Text{"Five Rubies", "Cinq Rubys", "Cinco rubíes"}, | ||
Text{"Rupoor (5)", "Roupir (5)", "Rupobre (5)"}}; | ||
trickNameTable[GI_RUPEE_RED] = { | ||
Text{"Red Rupy", "Rupee rouge", "Rubia roja"}, | ||
Text{"Twenty Rupees", "Vingt rubis", "Colon hyliano"}, | ||
Text{"Rupee (20)", "Rubis (20)", "Peso hyliano"}}; | ||
Text{"Big 20", "Grand 20", "Los 20 grandes"}, | ||
Text{"Twenty Rubies", "vingt rubis", "Veinte rubíes"}, | ||
Text{"Rupoor (20)", "Roupir (20)", "Rupobre (20)"}}; | ||
trickNameTable[GI_RUPEE_PURPLE] = { | ||
Text{"Purple Rupy", "Rupee pourpre", "Rubia morada"}, | ||
Text{"Fifty Rupees", "Cinquante rubis", "Balboa hyliano"}, | ||
Text{"Rupee (50)", "Rubis (50)", "Peso hyliano"}}; | ||
Text{"Purpee", "pourbi", "morupiua"}, | ||
Text{"Fifty Rubies", "cinquante rubis", "Cincuenta rubíes"}, | ||
Text{"Rupoor (50)", "Roupir (50)", "Rupobre (50)"}}; | ||
trickNameTable[GI_RUPEE_GOLD] = { | ||
Text{"Huge Rupy", "Énorme Rupee", "Rubia gigante"}, | ||
Text{"Two Hundred Rupees", "Deux cent rubis", "Euro hyliano"}, | ||
Text{"Rupee (200)", "Rubis (200)", "Dólar hyliano"}}; | ||
Text{"Hugo", "Or Rubi", "Oro Rubi"}, | ||
Text{"Two Hundred Rubies", "deux cents rubis", "Doscientos rubíes"}, | ||
Text{"Diamond", "Diamant", "Diamante"}}; | ||
trickNameTable[GI_HEART_PIECE] = { | ||
Text{"Piece of Health", "Quart d'énergie", "Pieza de amor"}, | ||
Text{"Recovery Heart", "Coeur d'énergie", "Corazón"}, | ||
Text{"Heart Container", "Réceptacle de coeur", "Contenedor de corazón"}}; | ||
Text{"Pizza Heart", "Fromage de cœur", "Pieza de Chorizo"}, | ||
Text{"Little Bit Of Love", "Un peu d'amour", "Un poco de amor"}, | ||
Text{"Rare Peach Stone", "Pierre de pêche rare", "Pierre de pêche rare"}}; | ||
trickNameTable[GI_HEART_CONTAINER_2] = { | ||
Text{"Health Container", "Réceptacle d'énergie", "Contenedor de amor"}, | ||
Text{"Recovery Heart", "Quart de coeur", "Corazón"}, | ||
Text{"Piece of Heart", "Coeur d'énergie", "Pieza de corazón"}}; | ||
Text{"Crystal Heart", "Cœur de cristal", "Corazón de cristal"}, | ||
Text{"Life Heart", "Cœur de vie", "Vida Corazón"}, | ||
Text{"Lots of Love", "Beaucoup d'amour", "Mucho amor"}}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here, old ones were better
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because it's not obvious, "Diamond" is a Zelda's adventure reference (where it's a special item that maxes your money) and the top row on the rupees are rando meme names.
…ove french translations.
Readded the older item names that were not obvious problem names, so they can be better sorted out later and don't hold this PR up, as well as the french suggestions. Also resolved #2682. And no worries about hate, I pushed things I expected to be bad on purpose to force things to happen, so a strong response is expected and welcomed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general I approve of these changes. The ability to have more trick names than 3 is great on it's own.
Text{"Bolero of Fire", "Boléro du feu", "Bolero del fuego"}}; | ||
Text{"Song of the Hero", "Chant du héros", "Canción del héroe"}}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed with @Pepper0ni here, if it was just the shops then the real song names on the wrong song would be fine but the situations where you can't see the actual item do make the real song names a bit unfair.
I'm going to go ahead and merge this now, if we find that we miss any of these trick names later we can always come back to this PR for the original names to get them back. And the ability to have more than three trick names is worth the PR by itself IMO. |
Resolves #3007 and #2945
The changes are:
EDIT: This PR has been greatly expanded to fix a wider array of text issues and in the process overhaul the trick names to make them a huge pile of references instead of just slight variations of the original item.
WARNING: I have tried to fill in the french and spanish translations for these, but I don't know either language, so it's just things copied from the wiki and some machine translations. I would really like it if a fluent french and spanish speaker gave it a look over (and tell me french/spanish rando meme names to replace the english ones as appropriate)
Build Artifacts