Fix linux auto rom detection for built-in extractor #842
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linux has special handling for directory searching that relies on
stat
. The issue was that the item names returned bydirent
were just the name of the file itself, not a real path. Sostat
was always returning an error when trying to search for rom flies. This would lead to "No roms found" modal even if there was a rom file next to the .appimage.This fixes it by building a real path using the passed in search path before querying
stat
and appending the path to the roms list.I'm not entirely sure why we search directories differently for each platform, as the
else
case usesstd::filesystem::directory_iterator
which was standardized in C++17, so a future improvement would be to drop the platform handling for the simple case.Build Artifacts