Various custom asset support #756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Archez
force-pushed
the
various-custom-asset-support
branch
from
832a6a5 to
9beeb83
Compare
Archez
force-pushed
the
various-custom-asset-support
branch
from
dc5655a to
a03d0a3
Compare
Archez
changed the title
|
Marking this as ready to review. The listed changes wrap up most of the reported issues with the mm reloaded pack. Remaining issues will be addressed in follow up PRs as these changes will be extensive enough to warrant individual PRs
|
inspectredc
approved these changes
Aug 19, 2024
|
Updated for PR feedback. Also found a few more resources that needed to be loaded manually so those have been added to the PR. |
inspectredc
approved these changes
Aug 20, 2024
mckinlee
pushed a commit
to mckinlee/2ship2harkinian
that referenced
this pull request
Oct 4, 2024
* use asset paths for better custom asset support * fix keyframe animation timings * display title cards as a full texture * asset support for gfxprint * support pause menu overworld map * fix more resources that need to be loaded * pr feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds various support of loading custom assets and toggling between assets (read: this is not meant to be all encompassing of every possible custom asset)
List so far of changes:
Lib_SegmentedToVirtualno longer loads resource data and instead will just pass through whatever pointer it is given. This will ensure that asset path strings end up to the renderer or later in some of the games systems (animations/skeletons)New issues introduced by these changes that need to be resolved:
Animation timings are incorrectManually load resources that are no longer freely loaded byLib_SegmentedToVirtual(mostly Vertex data)Build Artifacts