-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Item drops 3D! #633
Item drops 3D! #633
Conversation
Using kafeis cpp file is a no no lol. You'll need to create your own cpp and h file following the other enhancement examples and self contain your code within it. |
But It's within its own functions. I left the kafei functions untouched |
Each enhancement needs it's own separate file. |
Alright, I'll make a h and cpp file for it |
Alright, added two files |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should be able to pull this off without touching the actor’s file at all using the actor update & actor init hooks
Ah I'm not familiar with those tbh. |
78db338
to
549f426
Compare
bbc2d93
to
88cdc9b
Compare
Updated to use generic hooks & a few other tweaks |
I've updated this PR with latest develop and applied some fixes/changes:
If we wanted to render just the inner part of these rupees, we should setup new custom GID draw methods that just render the inner rupee part, but I don't think that is required for the scope of this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 Thanks to everyone who worked on this!
A good example of taking something from SoH, but porting it into hooks.
The changes for the slime actor in my opinion are fine as is, as we don't really have a good pattern for pulling something like that out.
* Initial 3D Item Drops Toggle * Use generic hooks and other tweaks * 3d drop fixes and changes * move slime item draw to VB hook; fix arrow GID * whitespacing --------- Co-authored-by: Garrett Cox <[email protected]> Co-authored-by: Archez <[email protected]>
Adds a toggle-able feature within
Enhancements->Graphics
to make Item drops 3D and spin. Most of the code is handled within a hook function in3DItemDrops.cpp
fileBuild Artifacts