Special char fix for dropped save files #611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Verified that this fixes the special character issue on windows as well. |
|
Verified by Will just yeet the function out completely and call it a day |
garrettjoecox
force-pushed
the
special-char-fix
branch
from
950780f to
2e660ce
Compare
garrettjoecox
force-pushed
the
special-char-fix
branch
from
2e660ce to
291973f
Compare
garrettjoecox
force-pushed
the
special-char-fix
branch
from
291973f to
77767b5
Compare
garrettjoecox
changed the title
Archez
approved these changes
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
SanitizePathfunction is entirely unnecessary, and causes issues when it tries to "fix" things.Test file and name to test with:
save!@#$%^&*()_+-=[]\{}|;'"<>?,\\//.json.jsonsave.json
Verified as working on MacOS, Windows, and Linux
Build Artifacts