Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds Dungeon Items to the Save Editor #585

Merged
merged 4 commits into from
Jun 3, 2024
Merged

Adds Dungeon Items to the Save Editor #585

merged 4 commits into from
Jun 3, 2024

Conversation

Caladius
Copy link
Contributor

@Caladius Caladius commented May 28, 2024 •
edited by github-actions bot
Loading

This adds a Dungeons Items tab to the Save Editor enabling the following features per Dungeon:

  • Adding/Removing Stray Fairies
  • Adding/Removing Dungeon Maps
  • Adding/Removing Dungeon Compasses
  • Adding/Removing Dungeon Small Keys (This pulls the max value for each dungeon into the Slider)
  • Adding/Removing Dungeon Boss Keys

This also adds the following outside of the Dungeon Items tab:

  • REMOVE_DUNGEON_ITEM, this is added to z64save.h as the macro did not exist.
  • Spin Lv2 Checkbox to the General tab in Save Editor, this unlocks the Level 2 Spin Slash the Woodfall Great Fairy awards.

Build Artifacts

garrettjoecox
garrettjoecox approved these changes May 29, 2024
View reviewed changes
mm/include/z64save.h Show resolved Hide resolved
mm/2s2h/DeveloperTools/SaveEditor.cpp Outdated Show resolved Hide resolved
@Caladius @garrettjoecox
Update mm/include/z64save.h
d5e9f8d 
Co-authored-by: Garrett Cox <[email protected]>
@garrettjoecox garrettjoecox added the enhancement New feature or request label Jun 2, 2024
@garrettjoecox garrettjoecox merged commit 26321c9 into HarbourMasters:develop Jun 3, 2024
5 checks passed
mckinlee pushed a commit to mckinlee/2ship2harkinian that referenced this pull request Oct 4, 2024
@Caladius @garrettjoecox @mckinlee
Adds Dungeon Items to the Save Editor (HarbourMasters#585)
7b08caf 
* Adds Dungeon Items to the Save Editor

* clang'd up

* Update mm/include/z64save.h

Co-authored-by: Garrett Cox <[email protected]>

* Move a few static arrays

---------

Co-authored-by: Garrett Cox <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@garrettjoecox garrettjoecox garrettjoecox approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Caladius @garrettjoecox