Fix Dpad Ocarina L Btn & GI Dpad Stuff #578
Conversation
inspectredc
force-pushed
the
dpad-ocarina-L-fix-cleanup
branch
from
ed23011 to
2f7287c
Compare
| @@ -230,3 +230,22 @@ int GameInteractor_InvertControl(GIInvertType type) { | |||
|
|
|||
| return result; | |||
| } | |||
|
|
|||
| uint32_t GameInteractor_Dpad(GIDpadType type, uint32_t buttonCombo) { | |||
There was a problem hiding this comment.
So what I had in mind here was more generic than being specific to just dpad, but to just controls in general. For instance, you call GameInteractor_Btn(GI_BTN_OCARINA_UP), and a player could opt in to using their dpad, or even right stick to count as "OCARINA_UP".
Does that make sense? Also not sold on the name GI_BTN, just an example
There was a problem hiding this comment.
I think sticks and buttons are a bit too different to handle them like that honestly but I get the generalisation yea.
There was a problem hiding this comment.
I want to revisit this, but when we know more / have a better idea
There was a problem hiding this comment.
Yea sure, do you think I should make a separate PR with the fix?
There was a problem hiding this comment.
oh wait nvm ur approving
Tried Following the Pattern from #441 Here
This should fix #544
Few thoughts on my part:
Build Artifacts