Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add draw distance enhancements for actors and scene geometry #539

Merged
merged 1 commit into from
Jun 3, 2024
Merged

Add draw distance enhancements for actors and scene geometry #539

merged 1 commit into from
Jun 3, 2024

Conversation

garrettjoecox
Copy link
Contributor

@garrettjoecox garrettjoecox commented May 27, 2024 •
edited by github-actions bot
Loading

Depends on Kenix3/libultraship#605

  • Adds a checkbox for disabling scene geometry culling
  • Add slider for multiplying actor draw distance check
  • Add slider for multiplying actor update distance check

Build Artifacts

@garrettjoecox garrettjoecox added the enhancement New feature or request label May 27, 2024
@garrettjoecox
Copy link
Contributor Author

Seems like this causes the clock town houses displayed from termina field to be hidden. Not a huge issue cause it's fairly minor and marked as "unstable" for now

@garrettjoecox garrettjoecox force-pushed the add-draw-distance-enhancements branch 6 times, most recently from 415e738 to 616067f Compare June 3, 2024 00:50
inspectredc
inspectredc approved these changes Jun 3, 2024
View reviewed changes
Copy link
Contributor

@inspectredc inspectredc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Idk if im a huge fan of the copied function but thats probably just because it's not documented, and I can't think of any other way of doing it really.

@garrettjoecox
Copy link
Contributor Author

Idk if im a huge fan of the copied function but thats probably just because it's not documented, and I can't think of any other way of doing it really.

Yeah that's fair, it's mostly to ensure we always preserve the vanilla behavior by default just in case we cause some sort of weird calculation error in our version.

@garrettjoecox garrettjoecox force-pushed the add-draw-distance-enhancements branch from 616067f to c5880c9 Compare June 3, 2024 04:03
@garrettjoecox garrettjoecox merged commit f8f00e6 into HarbourMasters:develop Jun 3, 2024
5 checks passed
@garrettjoecox garrettjoecox deleted the add-draw-distance-enhancements branch June 3, 2024 04:15
mckinlee pushed a commit to mckinlee/2ship2harkinian that referenced this pull request Oct 4, 2024
@garrettjoecox @mckinlee
Add draw distance enhancements for actors and scene geometry (Harbour…
262438e 
…Masters#539)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@inspectredc inspectredc inspectredc approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@garrettjoecox @inspectredc