Add persistent bunny mask enhancement #537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garrettjoecox
force-pushed
the
persistant-masks
branch
3 times, most recently
from
a102d4b to
8d5b3ca
Compare
|
Now using VB for restrictions override, and fixed an issue where the bunny hood would stay on if you didn't have it obtained |
garrettjoecox
force-pushed
the
persistant-masks
branch
6 times, most recently
from
5353fb7 to
843a730
Compare
inspectredc
reviewed
Jun 3, 2024
garrettjoecox
force-pushed
the
persistant-masks
branch
from
843a730 to
6c05fb3
Compare
Comments added! |
garrettjoecox
force-pushed
the
persistant-masks
branch
from
6c05fb3 to
cf4bf58
Compare
Archez
approved these changes
Jun 29, 2024
balloondude2
reviewed
Jul 6, 2024
mm/src/overlays/kaleido_scope/ovl_kaleido_scope/z_kaleido_scope_NES.c
Outdated
Show resolved
Hide resolved
garrettjoecox
force-pushed
the
persistant-masks
branch
2 times, most recently
from
4cef72e to
310be36
Compare
garrettjoecox
force-pushed
the
persistant-masks
branch
from
310be36 to
0ce38c7
Compare
mckinlee
pushed a commit
to mckinlee/2ship2harkinian
that referenced
this pull request
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enhancement allows you to always keep the bunny hood on, in combination with other masks and even other transformations.
The user experience of using this should be intuitive, it allows you to equip/un-equip the mask like normal, and lets you press "A" on the mask in kaleido to equip/unequip it
I intend to also add an option for doing the same thing with the Great fairy mask, but want to keep this PR separate from that.
Build Artifacts