Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Symfony 6 #315

Merged
merged 5 commits into from
Jan 19, 2022
Merged

Allow Symfony 6 #315

merged 5 commits into from
Jan 19, 2022

Conversation

KDederichs
Copy link
Contributor

Allow Symfony 6 and add PHP 8.1 to test matrix

@KDederichs
Copy link
Contributor Author

Fixes #314

@peter-gribanov
Copy link
Member

PHPSpec not support PHP 8.1 phpspec/phpspec#1406

@KDederichs
Copy link
Contributor Author

Good to know, removed that for now then :)

@peter-gribanov
Copy link
Member

Please add Symfony 6 compatibility check to the GitHub Action config:

- php-version: '8.0'
    dependencies: highest
    variant: 'doctrine/orm:~2.7 symfony/symfony:^6.0'

@KDederichs
Copy link
Contributor Author

Sure, also increased the PHP CS Fixer PHP Version, seems like that needs 7.4 now

@peter-gribanov peter-gribanov added this to the Release 2.0.2 milestone Jan 19, 2022
@peter-gribanov
Copy link
Member

Please try to change

-    variant: 'doctrine/orm:~2.7 symfony/symfony:^6.0'
+    variant: 'doctrine/orm:~2.7 symfony/property-access:^6.0'

@KDederichs
Copy link
Contributor Author

KDederichs commented Jan 19, 2022

Done, hope that fixes it cause otherwise PHPSpec needs to be updated as well?

@peter-gribanov peter-gribanov merged commit 668dd79 into Happyr:2.x Jan 19, 2022
@peter-gribanov
Copy link
Member

Thanks for your work 👍

@peter-gribanov
Copy link
Member

Released in v2.0.2.

@peter-gribanov peter-gribanov mentioned this pull request Jan 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants