A "LIKE" specification

[AP-Hunt]

Nyholm, cakper

I really like your library. I've evaluated it for use at work, and it seems really easy to use and extend. Whilst using it, though, I found a couple of little things I thought were missing.

This pull request is for the first of the missing things I identified: a "like" specification. It's pretty simple and builds on your existing work with other types of comparison. I'm not sure how I feel about taking a pattern as the format and calling sprintf($format, $value), but I think it works for a first iteration.

I'm also not sure about the order of the parameters. I think it'd be more readable to take the format between field and value parameters (ie new S\Like("baz", S\Like::CONTAINS, "bing")), but that wouldn't match the signature of the other specifications and wouldn't allow a default parameter. What do you think?

Usage example:

use Happy\Doctrine\Specification\Spec as S;
// ...
$spec new S\AndX(
    new S\Equals("foo", "bar"),
    new S\Like("baz", "bing", S\Like::STARTS_WITH)
)

Regards,
Andy

P.S. Do the spec tests look OK? I've not used PHPSpec before.

[coveralls]

Coverage increased (+1.04%) when pulling fccca36 on AndyBursh:master into 35e4b22 on Happyr:master.

[coveralls]

Coverage increased (+0.3%) when pulling 668ce73 on AndyBursh:master into 35e4b22 on Happyr:master.

[AP-Hunt]

My apologies, I pushed an extra commit (668ce73) here for something else. I didn't expect it to also add it to this pull request.

[Nyholm]

Thank you @AndyBursh for your PR.
I like the order of the parameters that you've submitted. I know that new S\Like("baz", S\Like::CONTAINS, "bing") is easier to read but good coding standards say that optional parameters should be at the end. So keep it the way you have it now.

I think the PHPSpec looks good. @cakper is really the expert there =)

I would like you to add a factory function for the Like spec. Just ad a function in this class.

[coveralls]

Coverage increased (+0.79%) when pulling a040cf5 on AndyBursh:master into 35e4b22 on Happyr:master.

[AP-Hunt]

Of course, not a problem. The factory method is implemented in a040cf5.

[cakper]

👍 thanks for your work :) specs are good :) nothing to add there, I'm happy that you managed to write them even tho you never used PhpSpec

@Nyholm I'm fine with this PR, mergning

[Nyholm]

👍