Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Сhange CountDistinct to Count platform function #285

Merged
merged 1 commit into from
Jan 25, 2021

Conversation

peter-gribanov
Copy link
Member

Сombine Spec::countDistinct() and Spec::COUNT() into one method/class.

Upgrade

  • The Happyr\DoctrineSpecification\Operand\CountDistinct class was removed, use
    Happyr\DoctrineSpecification\Operand\PlatformFunction\Count instead.

  • The Spec::countDistinct() method was removed, use Spec::COUNT() instead.

    Before:

    new CountDistinct('field_name');
    Spec::countDistinct('field_name');

    After:

    new Count('field_name', true);
    Spec::COUNT('field_name', true);
  • The COUNT function as argument to Spec::fun() is not longer supported, use Spec::COUNT() instead.

  • The COUNT function as argument to Happyr\DoctrineSpecification\Operand\PlatformFunction is not longer supported,
    use Spec::COUNT() instead.

    Before:

    new PlatformFunction('COUNT', 'field_name');
    Spec::fun('COUNT', 'field_name');

    After:

    new Count('field_name');
    Spec::COUNT('field_name');

@peter-gribanov peter-gribanov self-assigned this Jan 25, 2021
@peter-gribanov peter-gribanov added this to the Release 2.0.0 milestone Jan 25, 2021
@peter-gribanov peter-gribanov force-pushed the count_distinct branch 2 times, most recently from 289b34c to b64801d Compare January 25, 2021 12:00
@peter-gribanov peter-gribanov mentioned this pull request Jan 25, 2021
37 tasks
@peter-gribanov peter-gribanov merged commit d7d09e6 into Happyr:2.0 Jan 25, 2021
@peter-gribanov peter-gribanov deleted the count_distinct branch January 25, 2021 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant