Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pedantic fixes #267

Merged
merged 1 commit into from
Dec 9, 2020
Merged

Pedantic fixes #267

merged 1 commit into from
Dec 9, 2020

Conversation

peter-gribanov
Copy link
Member

  • Fix typo in annotations;
  • Add ASC and DESC constants in OrderBy spec;
  • Rename some variables;
  • Don't check that $query->getParameters() instance of Parameter. This is always true for Doctrine ORM >= 2.3

@peter-gribanov peter-gribanov self-assigned this Dec 9, 2020
@peter-gribanov peter-gribanov added this to the Release 2.0.0 milestone Dec 9, 2020
@peter-gribanov peter-gribanov merged commit a566e1f into Happyr:2.0 Dec 9, 2020
@peter-gribanov peter-gribanov deleted the annotations branch December 9, 2020 08:23
@peter-gribanov peter-gribanov restored the annotations branch December 10, 2020 15:40
@peter-gribanov peter-gribanov deleted the annotations branch December 10, 2020 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant