Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove build badge of SensioLabsInsight linked to different project #240

Merged
merged 2 commits into from
Jun 15, 2020
Merged

Remove build badge of SensioLabsInsight linked to different project #240

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8f13bf2
remove build badge of SensioLabsInsight linked to different project
peter-gribanov Jun 15, 2020
fe9870b
Merge branch 'master' into SensioLabsInsight
peter-gribanov Jun 15, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
[![Latest Stable Version Packagist](https://img.shields.io/packagist/v/happyr/doctrine-specification.svg)](https://packagist.org/packages/happyr/doctrine-specification)
[![Monthly Downloads Packagist](https://img.shields.io/packagist/dm/happyr/doctrine-specification.svg)](https://packagist.org/packages/happyr/doctrine-specification)
[![Total Downloads Packagist](https://img.shields.io/packagist/dt/happyr/doctrine-specification.svg)](https://packagist.org/packages/happyr/doctrine-specification)
[![SensioLabsInsight](https://insight.sensiolabs.com/projects/44c425af-90f6-4c25-b789-4ece28b01a2b/mini.png)](https://insight.sensiolabs.com/projects/44c425af-90f6-4c25-b789-4ece28b01a2b)
[![Quality Score](https://img.shields.io/scrutinizer/g/happyr/doctrine-specification.svg)](https://scrutinizer-ci.com/g/happyr/doctrine-specification)

This library gives you a new way for writing queries. Using the [Specification pattern][wiki_spec_pattern] you will
Expand Down Expand Up @@ -191,7 +190,7 @@ class AdvertRepository extends EntityRepository
The issues with the QueryBuilder implementation are:

* You may only use the filters `filterOwnedByCompany` and `filterAdvertsWeShouldClose` inside AdvertRepository.
* You can not build a tree with And/Or/Not. Say that you want every Advert but not those owned by $company. There
* You can not build a tree with And/Or/Not. Say that you want every Advert but not those owned by $company. There
is no way to reuse `filterOwnedByCompany()` in that case.
* Different parts of the QueryBuilder filtering cannot be composed together, because of the way the API is created.
Assume we have a filterGroupsForApi() call, there is no way to combine it with another call filterGroupsForPermissions().
Expand Down