Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: remove unsupported PHP versions #182

Closed
wants to merge 1 commit into from
Closed

Conversation

XWB
Copy link
Contributor

@XWB XWB commented Apr 26, 2019

PHP 5.5 and 7.0 are EOL.

@peter-gribanov
Copy link
Member

I'm not sure that it is a good idea to discard PHP 5 in this project.
Of course, PHP 5 is outdated and must be abandoned. I would want to go to PHP 7 and use type hinting in the project. But i don't think it's a good idea to do it now. I would want that users of old PHP versions could use features of operands #169.
I plan to set the PHP 7.2 as the minimum requirement for the next major release 2.0. I think it will be in this year.

PS: PHP 5.6 is unsupported too.

@XWB
Copy link
Contributor Author

XWB commented Apr 26, 2019

I'm not sure that it is a good idea to discard PHP 5 in this project.

That's why I kept PHP 5.6 in the requirements.

I don't think open source projects should encourage the usage of old PHP versions, but I'd be happy to wait for the next major release though :)

@XWB XWB deleted the php branch April 26, 2019 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants