Fix grammar and spelling in user-facing messages - #2580
Merged
Conversation
odinserj
approved these changes
Jul 20, 2026
net0well
force-pushed
the
fix-user-facing-message-typos
branch
from
July 20, 2026 11:24
b8ffc67 to
41ec6a3
Compare
Correct several long-standing typos in messages that are surfaced to users through logs, exceptions and the Dashboard UI: - AutomaticRetryAttribute: "an exception occured" -> "an exception occurred" in the warning logged when a job is automatically deleted after exceeding the maximum number of retry attempts. - CoreBackgroundJobFactory: "because it doesn't exists" -> "because it doesn't exist" in the InvalidOperationException thrown when a background job can't be initialized during creation retries. - DisableConcurrentExecutionAttribute: "greater that zero" -> "greater than zero" in the ArgumentException thrown when a negative timeout value is passed to the constructor. - Dashboard (Strings.resx): "Cron expression is invalid or don't have any occurrences" -> "Cron expression is invalid or doesn't have any occurrences" in the disabled recurring job resource files are not affected since each culture provides it value for this key. Only string literals are changed, so there is no behavior change, and no existing tests assert these exact messages.
net0well
force-pushed
the
fix-user-facing-message-typos
branch
from
July 20, 2026 11:33
41ec6a3 to
67944ae
Compare
Member
|
Thank you, @net0well! |
This was referenced Aug 28, 2026
Bump Hangfire.AspNetCore from 1.8.23 to 1.8.25
vehiclevisionjp/VehicleVision.Pleasanter.JobRunner#28
Open
Open
This was referenced Aug 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Correct several long-standing typos in messages that are surfaced to users through logs, exceptions and the Dashboard UI:
AutomaticRetryAttribute: "an exception occured" -> "an exception occurred" in the warning logged when a job is automatically deleted after exceeding the maximum number of retry attempts.
CoreBackgroundJobFactory: "because it doesn't exists" -> "because it doesn't exist" in the InvalidOperationException thrown when a background job can't be initialized during creation retries.
DisableConcurrentExecutionAttribute: "greater that zero" -> "greater than zero" in the ArgumentException thrown when a negative timeout value is passed to the constructor.
Dashboard (Strings.resx): "Cron expression is invalid or don't have any occurrences" -> "Cron expression is invalid or doesn't have any occurrences" in the disabled recurring job resource files are not affected since each culture provides it value for this key.
Only string literals are changed, so there is no behavior change, and no existing tests assert these exact messages.