Improve display of job result and properties (followup) #2396
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a followup to #1509 which was closed on the ground that the new
UseJobDetailsRenderer
method could be used.While technically possible to achieve (see https://github.com/0xced/Hangfire.TidyDashboard) it's a lot of work: reimplement the
Hangfire.Dashboard.JobHistoryRenderer.SucceededRenderer
method in order to prettify the JSON and the newlines and wrap a JobStorageMonitor in order to prettify the parameters.It think this makes much more sense to have this prettifying of strings built-in to the Hangfire dashboard.
Note
I have also fixed a bug compared to the original pull request where non-string job parameters would be double html escaped.
Original description
It's quite common that job properties and/or result are strings. Since everything is serialized as JSON in the database, a string becomes quoted and has escaped characters. For displaying in the dashboard, it's nicer without the quotes and escaped characters.
Before this pull request:
![HangFire-ugly](https://private-user-images.githubusercontent.com/51363/323885133-637aa0af-b12f-4a5e-adb4-30e3d28dda2c.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjExMzI0NTMsIm5iZiI6MTcyMTEzMjE1MywicGF0aCI6Ii81MTM2My8zMjM4ODUxMzMtNjM3YWEwYWYtYjEyZi00YTVlLWFkYjQtMzBlM2QyOGRkYTJjLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MTYlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzE2VDEyMTU1M1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPThiNTkxZTZmMThjZGI1OWMyMDI0NDMyODU0NDRhMDM1NTk5NjMzN2RkNzEwMDY5N2ZhYTBlOGFkYjhkZGViZDEmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.Ed9jQeWjrewHZvCAl8R4qiL0ic0RJQGXltgKm8sJ0FA)
After this pull request:
![HangFire-pretty](https://private-user-images.githubusercontent.com/51363/323885185-19a23240-8777-48b7-b33b-3ab08eb4bc1d.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjExMzI0NTMsIm5iZiI6MTcyMTEzMjE1MywicGF0aCI6Ii81MTM2My8zMjM4ODUxODUtMTlhMjMyNDAtODc3Ny00OGI3LWIzM2ItM2FiMDhlYjRiYzFkLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MTYlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzE2VDEyMTU1M1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTRkMjIwMTdjNjhlZTJmZDQ0ZGU5MTZlZGUzMjYwNDE0NjZlOTI5MDI5ZWVjZDRiZWFjZGJhYzc1ZmIxZmVkODYmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.KlaSrH7iS9X72h_IEzruGH1WWdztww6jMvjWhU-4R_w)