Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update of TFM & dependency optimisation #578

Merged

Conversation

thompson-tomo
Copy link
Contributor

@thompson-tomo thompson-tomo commented Apr 1, 2024

By adjusting the TFM'S we have been able to produce a package with no dependencies on the latest frameworks hence an optimised dependency graph.

The following frameworks have been added:

  • Net 6

The following frameworks even though requested was not added:

  • Net 5

The following frameworks were removed:

  • Net 4.5.2
  • Net 4.6

Closes: #573
Closes: #415

Copy link
Member

@oformaniuk oformaniuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider dropping net5 as it is not supported anymore and adding net8.

@thompson-tomo
Copy link
Contributor Author

thompson-tomo commented Apr 2, 2024

I don't see a benefit in adding dotnet 8 as the dotnet 6 compilation will be used. Will remove net 5.

Thoughts on also dropping net 452, net 46 as it is the same as the net 451 compilation.

@thompson-tomo thompson-tomo changed the title Add in Net 5 & 6 Update of TFM & dependency optimisation Apr 2, 2024
@oformaniuk
Copy link
Member

Thoughts on also dropping net 452, net 46 as it is the same as the net 451 compilation.

Yes, this is a good idea to optimize monikers 👍

Copy link

sonarcloud bot commented Apr 2, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@thompson-tomo
Copy link
Contributor Author

@oformaniuk i have just gone & dropped those 2 TFM's from the package.

@oformaniuk oformaniuk merged commit 837fc18 into Handlebars-Net:master Apr 2, 2024
7 checks passed
@thompson-tomo thompson-tomo deleted the chore/#573_AddAdditionalTFM branch April 2, 2024 18:25
@oformaniuk
Copy link
Member

@thompson-tomo
Copy link
Contributor Author

thompson-tomo commented Apr 3, 2024

@oformaniuk should be Fixed in #579

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve dependency graph by adding TFM Any porting available for .net core 5.0
2 participants