Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add EmbedUntrackedSources #570

Merged
merged 3 commits into from
Apr 1, 2024

Conversation

lahma
Copy link
Contributor

@lahma lahma commented Feb 16, 2024

I would also suggest changing to use newer GH Actions images for building so that other warnings would go away (old SDK in use). Maybe another modernization step could be removing old unsupported full framework targets and only support oldest supported net462. Adding net6.0 target would allow one target without dependency on Microsoft.Csharp.

@StefH
Copy link
Collaborator

StefH commented Feb 16, 2024

@lahma
Thank you.
But actually the "license expression" is already fixed by me (#564)

About EmbedUntrackedSources --> that's ok.

And thanks about the hint for "newer GH Actions images", I'll take a look.

@lahma
Copy link
Contributor Author

lahma commented Feb 16, 2024

Ah, great minds think a like I guess 😄 I've updated the PR title and contents to only contain EmbedUntrackedSources set to true

@lahma lahma changed the title Add PackageLicenseExpression Add EmbedUntrackedSources Feb 16, 2024
Copy link

sonarcloud bot commented Feb 16, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

sonarcloud bot commented Apr 1, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@oformaniuk oformaniuk merged commit bed0c0e into Handlebars-Net:master Apr 1, 2024
7 checks passed
@lahma lahma deleted the license-expression branch April 1, 2024 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants