Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix windowHints bugs with utf8 chars #3243

Merged
merged 1 commit into from
Mar 6, 2023
Merged

Fix windowHints bugs with utf8 chars #3243

merged 1 commit into from
Mar 6, 2023

Conversation

twio142
Copy link
Contributor

@twio142 twio142 commented Jun 21, 2022

  1. Fix window titles broken from truncating
  2. When using hint chars vimperator, use the parent app's file name as a fallback, in case the app's title starts with a utf8 char. (fix windowHints vimperator: Limits on Non-English systems #3239)

1. Fix window titles broken from truncating
2. When using hint chars vimperator, use the parent app's file name as a fallback, in case the app's title starts with a utf8 char.
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request does not contain a valid label. Please add one of the following labels: pr-fix, pr-change, pr-feature, pr-maintenance

@cmsj cmsj merged commit 1688862 into Hammerspoon:master Mar 6, 2023
@twio142 twio142 deleted the patch-1 branch March 6, 2023 10:53
@cmsj cmsj added the pr-fix Pull Request implementing a bug fix label Mar 12, 2023
@cmsj cmsj changed the title fix windowHints bugs with utf8 chars Fix windowHints bugs with utf8 chars Mar 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-fix Pull Request implementing a bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

windowHints vimperator: Limits on Non-English systems
2 participants