Fix hs.application.get() always returning nil

[amlestin]

for #3206

pr-fix

[github-actions]

This pull request does not contain a valid label. Please add one of the following labels: pr-fix, pr-change, pr-feature, pr-maintenance

[andmis]

I'd love to see this get merged at some point!

[amlestin]

I'd love to see this get merged at some point!

Do you know how I can add a pr-fix label to fix the workflow?

[andmis]

I'd love to see this get merged at some point!

Do you know how I can add a pr-fix label to fix the workflow?

Nope, unfortunately I don't. I'm not a maintainer or anything, just a bystander / cheerleader!

[amlestin]

I'd love to see this get merged at some point!

Do you know how I can add a pr-fix label to fix the workflow?

Nope, unfortunately I don't. I'm not a maintainer or anything, just a bystander / cheerleader!

Thanks anyway :) I think only the repo owner can edit it.

[latenitefilms]

I believe only @asmagill and @cmsj have the power to assign labels.

[cmsj]

Added the label and kicked the CI off, not that I would particularly expect the results to be relevant here (and don't worry if there are unrelated failures - some of our tests are just unreliable, unfortunately!)

[cmsj]

Just one other thing: I'm quite short on time at the moment, but I'd like to dig into this a little deeper before merging, just to make sure we're not invalidating other assumptions somehow.

[github-actions]

View Test Results

342 tests   290 ✔️  11m 24s ⏱️
    2 suites    52 💤
    1 files        0 ❌

Results for commit b58d959.

♻️ This comment has been updated with latest results.

[cmsj]

@amlestin this seems to include an unrelated change to the hs.json tests - was that intentional?

[amlestin]

@cmsj that failing test was blocking the pipeline

https://github.com/Hammerspoon/hammerspoon/runs/6688462569?check_suite_focus=true#step:8:401

[cmsj]

Thanks, and sorry this has taken so long!