docs: test PR signature format - #1
Closed
Halldrix wants to merge 1 commit into
Closed
Conversation
Testing the Halldrix + Hermes Agent signature block for PRs.
Halldrix
pushed a commit
that referenced
this pull request
Aug 15, 2026
Addresses both review findings on the remote-gateway download PR: 1. Unbounded buffering (finding #1). fetchBuffer / fetchBufferViaOauthSession accumulated the entire response (then copied it again via Buffer.concat) before saveGatewayFile even opened the save dialog, so a large gateway file could exhaust the native process. Both auth paths now stream: once response headers arrive the connect timeout is cleared, the filename is derived, the save dialog is shown, and the body is piped to the chosen destination with backpressure. A read/write error tears down the stream and unlinks the partial file. The byte-moving, data-URL decoding, and filename/path helpers are extracted into gateway-file-download.ts so they're unit-testable without Electron. 2. No fallback for older gateways (finding NousResearch#2). saveGatewayFile required the new /api/fs/download route. Desktop and the remote gateway update independently, so a gateway predating this PR 404s. Added a 404-only compatibility fallback to the existing capped /api/fs/read-data-url route (bounded, so it only serves smaller files — enough to keep older backends working). Tests: gateway-file-download.test.ts covers streaming, backpressure, error-cleanup (unlink on write/response error), data-URL decoding, filename derivation (incl. traversal reduction), and 404 detection; gateway-file-download-transport.test.ts asserts both transports stream (no whole-body Buffer.concat) and that the 404 fallback is wired. Both registered in the desktop platform test list. Server-side /api/fs/download tests (streaming + sensitive-file reject) already pass. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Halldrix
pushed a commit
that referenced
this pull request
Aug 15, 2026
…-renders (NousResearch#81726) The scoped find walker wraps transcript text nodes in <mark> elements that React does not own. Assistant responses stream through markdown-text.tsx, which rebuilds the markdown DOM on every delta, and a new message is appended whenever the assistant answers — so a re-render of a changed region detaches the marks we inserted, dropping the user's highlights while the bar stays open. Watch the captured scope with a MutationObserver and re-wrap only when an unmarked occurrence of the active query actually reappears. The observer is gated behind a re-entrancy flag while the walker is mutating, coalesced to one re-apply per microtask, torn down when the bar closes or the query clears, and restores the active ordinal so a mid-stream re-render doesn't reset the user's place to match #1. An append that adds no matching text is a no-op; re-wrapping only fires when highlights genuinely went stale. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Halldrix
added a commit
that referenced
this pull request
Aug 16, 2026
…eOperations `_schedule_replace_on_reboot` queues `MoveFileExW(MOVEFILE_DELAY_UNTIL_REBOOT)` pairs into the Session Manager registry so a locked `hermes.exe` can be renamed aside on next boot. Neither success nor failure of the subsequent recovery install removes the queued entries, so across repeated failed boot-recoveries they accumulate (one per failed boot — the NousResearch#85839 report counted 12). On the next reboot the Session Manager applies entry #1, renaming the current, healthy `hermes.exe` to a `.old.` backup — the shim vanishes after a reboot that was supposed to fix things. Add `_cleanup_pending_file_rename_operations()` (called from `_cleanup_quarantined_exes` on every launch) that scans the `PendingFileRenameOperations` registry value and removes hermes-shim pairs whose source file no longer exists (the shim was rewritten by a later install — the pending rename is a booby trap) or whose `.old.` target backup no longer exists (stale pair from a failed cycle). Non-hermes entries are left untouched. Fixes NousResearch#85839 🛠️ Dev: Halldrix 🤖 Sidekick: Hermes Agent v0.20.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing the Halldrix + Hermes Agent signature block for pull requests.
This PR adds a minor HTML comment marker to
AGENTS.mdto verify how the signature renders in GitHub's PR interface.🛠️ Dev: Halldrix
🤖 Sidekick: Hermes Agent v0.20.0
🧠 Status: Human-reviewed & verified by Halldrix