Only set long expiration for files in _app/immutable directory#29
Merged
HalfdanJ merged 2 commits intoHalfdanJ:mainfrom Jul 5, 2022
Merged
Conversation
Owner
|
With #28 merged, can you try and rebase / merge to master. Also, integration test needs to be updated to contain the new expected yaml in |
Contributor
Author
|
HI @HalfdanJ and sorry I completely missed the notifications on the PRs. I see you already merged the other one. I'll rebase this one and update the integration tests. |
a09ce8b to
ea0f2e7
Compare
Contributor
Author
Owner
|
Thanks @sfriedel ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recently SvelteKit introduced the
_app/immutabledirectory in the buildout. This directory contains all files that should be cached with a long TTL. Serving the whole_app/directory with a long TTL impacts the SvelteKit update check via theupdatedstore from$app/stores(see: https://kit.svelte.dev/docs/modules#$app-stores-updated) which relies on being able to fetch the current app version from_app/version.json.This PR splits the handlers for
_app/and_app/immutableand only sets the 30d expiration on the_app/immutablehandler. Other assets in_app/are then served with the default expiration which can further be customized by settingdefault_expirationin the top-levelapp.yaml.Similar changes in the default adapters were introduced in sveltejs/kit#5051