Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update aws-sdk-s3 to 0.35 #43

Closed
wants to merge 4 commits into from
Closed

Conversation

jwangnz
Copy link
Contributor

@jwangnz jwangnz commented Nov 1, 2023

No description provided.

@Hakuyume
Copy link
Owner

Hakuyume commented Nov 4, 2023

We also need to update aws-config in dev-dependencies.

@jwangnz jwangnz changed the title Update aws-sdk-s3 to 0.34 Update aws-sdk-s3 to 0.35 Nov 6, 2023
@jwangnz
Copy link
Contributor Author

jwangnz commented Nov 6, 2023

@Hakuyume Updated the aws-sdk-s3 to 0.35 with aws-config updated to 0.57

@jwangnz
Copy link
Contributor Author

jwangnz commented Nov 6, 2023

@Hakuyume Add additional commits to adjust the changes from 0.35:

}
}

impl Unpin for WrappedByteStream {}
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Usually, implementing Unpin manually is bad idea since the compiler infers Unpin automatically.

@Hakuyume
Copy link
Owner

Hakuyume commented Nov 8, 2023

@Tsing thank you for your contribution. I updated in #44 .

@Hakuyume Hakuyume closed this Nov 8, 2023
@jwangnz jwangnz deleted the aws-sdk-s3-0.34 branch November 8, 2023 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants