[TESTS] Added unit tests for bonding #1559
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethouris
added
Type: Maintenance
[ RUN ] Bonding.ConnectNonBlocking
Created group socket: 1428448644
Connecting two sockets
[A] Waiting for accept
Connect callback. Socket: 354706819, error: 0, token: 3
Returned from connecting two sockets
/Users/travis/build/Haivision/srt/test/test_bonding.cpp:162: Failure
Expected equality of these values:
ev[0].events
Which is: 17
SRT_EPOLL_IN
Which is: 1
Connect callback. Socket: 354706818, error: 0, token: 4
[ FAILED ] Bonding.ConnectNonBlocking (1188 ms) |
|
LOL actually didn't expect that the uwait might report IN and UPDATE in one. That case is also to be tolerated, I'll make a fix. |
added 5 commits
October 21, 2020 16:34
…ue for connect-non-blocking
Codecov Report
@@ Coverage Diff @@
## master #1559 +/- ##
==========================================
+ Coverage 60.74% 63.50% +2.75%
==========================================
Files 78 78
Lines 17444 17762 +318
==========================================
+ Hits 10596 11279 +683
+ Misses 6848 6483 -365
Continue to review full report at Codecov.
|
added 5 commits
December 8, 2020 11:40
… exit checks in tsbpd. Suppressed IPE log when unsubscribing
…tsbpd_cc wait 125ms interrupt for sanity check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added tests:
TEST(Bonding, ConnectBlind)
Connect to a nonexistent endpoint and interrupt it by closing a group.
TEST(Bonding, ConnectNonBlocking)
Test connecting with non-blocking mode and correctly reported epoll events.
TEST(Bonding, BackupPriorityBegin)
Setup two links with different weight and expect the one with higher priority to be activated.
TEST(Bonding, BackupPriorityTakeover)
Setup a new link while in transmission and expect the new link with higher priority takes over, even if there's no need to backup.
TEST(Bonding, BackupPrioritySelection)
Setup two links with high priority and send a packet to activate one. Then connect a link with low priority, kill the active link and send the packet - expected is that the out of two remaining link, the one with higher priority is activated.